linux-kernel - Re: [PATCH 1/1 linux-next] IB/mthca: use swap() in mthca_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Jun 2015 11:24:17 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Julia Lawall <Julia.Lawall@...6.fr>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] IB/mthca: use swap() in mthca_make_profile()

On 06/10/2015 12:31 PM, Fabian Frederick wrote:
> Use kernel.h macro definition.
> 
> Thanks to Julia Lawall for Coccinelle scripting support.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Thanks, applied.

> ---
>  drivers/infiniband/hw/mthca/mthca_profile.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mthca/mthca_profile.c b/drivers/infiniband/hw/mthca/mthca_profile.c
> index 8edb28a..15d0644 100644
> --- a/drivers/infiniband/hw/mthca/mthca_profile.c
> +++ b/drivers/infiniband/hw/mthca/mthca_profile.c
> @@ -77,7 +77,6 @@ s64 mthca_make_profile(struct mthca_dev *dev,
>  	u64 mem_base, mem_avail;
>  	s64 total_size = 0;
>  	struct mthca_resource *profile;
> -	struct mthca_resource tmp;
>  	int i, j;
>  
>  	profile = kzalloc(MTHCA_RES_NUM * sizeof *profile, GFP_KERNEL);
> @@ -136,11 +135,8 @@ s64 mthca_make_profile(struct mthca_dev *dev,
>  	 */
>  	for (i = MTHCA_RES_NUM; i > 0; --i)
>  		for (j = 1; j < i; ++j) {
> -			if (profile[j].size > profile[j - 1].size) {
> -				tmp            = profile[j];
> -				profile[j]     = profile[j - 1];
> -				profile[j - 1] = tmp;
> -			}
> +			if (profile[j].size > profile[j - 1].size)
> +				swap(profile[j], profile[j - 1]);
>  		}
>  
>  	for (i = 0; i < MTHCA_RES_NUM; ++i) {
> 



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)