linux-kernel - Re: [PATCH] staging: ste_rmi4: Add IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150612153649.GB30967@kroah.com>
Date:	Fri, 12 Jun 2015 08:36:49 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>
Cc:	"vthakkar1994@...il.com" <vthakkar1994@...il.com>,
	"hamohammed.sa@...il.com" <hamohammed.sa@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tapaswenipathak@...il.com" <tapaswenipathak@...il.com>
Subject: Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

On Fri, Jun 12, 2015 at 06:47:25AM +0000, Abdul, Hussain (H.) wrote:
> On Thursday 11 June 2015 08:06 PM, gregkh@...uxfoundation.org wrote:
> > On Thu, Jun 11, 2015 at 10:14:49AM +0000, Abdul, Hussain (H.) wrote:
> >> This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler.
> >>
> >> Signed-off-by: Abdul Hussain <habdul@...teon.com>
> >> ---
> >>  drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> >> index 0f524bb..7caaae0 100644
> >> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> >> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> >> @@ -987,7 +987,7 @@ static int synaptics_rmi4_probe
> >>  				rmi4_data->number_of_interrupt_register);
> >>  	retval = request_threaded_irq(client->irq, NULL,
> >>  					synaptics_rmi4_irq,
> >> -					platformdata->irq_type,
> >> +					platformdata->irq_type | IRQF_ONESHOT,
> >>  					DRIVER_NAME, rmi4_data);
> >>  	if (retval) {
> >>  		dev_err(&client->dev, "Unable to get attn irq %d\n",
> > Have you tested this?  This changes the behavior of the code, right?
> >
> Greg,
> 
> I haven't tested this changes. Yes, this will change the behavior of the code.

Then I can't accept this, sorry.  Why would you make a behavior change
without testing something?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/