linux-kernel - Re: [Patch V2 2/3] usb: Introduce Xen pvUSB frontend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150612162007.GC15911@kroah.com>
Date:	Fri, 12 Jun 2015 09:20:07 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Juergen Gross <jgross@...e.com>
Cc:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	konrad.wilk@...cle.com, david.vrabel@...rix.com,
	boris.ostrovsky@...cle.com, linux-usb@...r.kernel.org
Subject: Re: [Patch V2 2/3] usb: Introduce Xen pvUSB frontend

On Fri, Jun 12, 2015 at 04:10:00PM +0200, Juergen Gross wrote:
> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
> domU to communicate with a USB device assigned to that domU. The
> communication is all done via the pvUSB backend in a driver domain
> (usually Dom0) which is owner of the physical device.
> 
> The code is taken from the pvUSB implementation in Xen done by Fujitsu
> based on Linux kernel 2.6.18.
> 
> Changes from the original version are:
> - port to upstream kernel
> - put all code in just one source file
> - move module to appropriate location in kernel tree
> - adapt to Linux style guide
> - minor code modifications to increase readability
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>
> ---
>  drivers/usb/Kconfig            |    2 +
>  drivers/usb/Makefile           |    2 +
>  drivers/usb/xen/Kconfig        |   10 +
>  drivers/usb/xen/Makefile       |    5 +
>  drivers/usb/xen/xen-usbfront.c | 1647 ++++++++++++++++++++++++++++++++++++++++

A subdirectory for a single file?  That seems like overkill, don't you
think?  As this is a USB "host" driver, why not put it in that
directory?

Also, last time these patches were posted, people asked why you can't
use libusb/usbfs instead, what happened with that?  Or usbip?

> +config XEN_USB_FRONTEND
> +	tristate "Xen USB frontend driver"
> +	depends on XEN
> +	default m

Remove this, default should be 'n'.

> +/* status of attached device */
> +struct vdevice_status {
> +	int devnum;
> +	enum usb_device_state status;
> +	 enum usb_device_speed speed;
> +};

Always run your patches through checkpatch.pl so people don't tell you
about the things that checkpatch.pl would have told you about...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/