linux-kernel - Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqL6R5jz1Xhgav0a0SeWqcRT200sofP-G_zQLfDVeqwarA@mail.gmail.com>
Date:	Thu, 11 Jun 2015 22:13:21 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Mark Brown <broonie@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	David Collins <collinsd@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> Add support for over current protection (OCP), pin control
> selection, soft start and soft start strength, auto-mode, input
> current limiting, and pull down.
>
> Cc: <devicetree@...r.kernel.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>
> Changes from v1:
> * New patch split from original SPMI regulator driver
>
>  .../bindings/regulator/qcom,spmi-regulator.txt     |  62 +++++
>  drivers/regulator/qcom_spmi-regulator.c            | 298 ++++++++++++++++++++-
>  2 files changed, 358 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> index 75b4604bad07..ab01a152e930 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> @@ -99,6 +99,68 @@ see regulator.txt - with additional custom properties described below:
>                     soft start are active all the time. 0 = Set initial mode to
>                     low power mode (LPM).
>
> +- qcom,auto-mode-enable:

Auto regulator modes are fairly common. Can't we have a common property here?

> +       Usage: optional
> +       Value type: <u32>

This can be bool. Unless we want to have a mode property with "auto"
being one possible value.

> +       Description: 1 = Enable automatic hardware selection of regulator
> +                        mode (HPM vs LPM); not available on boost type
> +                        regulators. 0 = Disable auto mode selection.
> +
> +- qcom,ocp-enable:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: 1 = Allow over current protection (OCP) to be enabled for
> +                    voltage switch type regulators so that they latch off
> +                    automatically when over current is detected. OCP is
> +                    enabled when in HPM or auto mode.  0 = Disable OCP.

This seems common too.

> +
> +- qcom,ocp-max-retries:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: Maximum number of times to try toggling a voltage switch
> +                    off and back on as a result of consecutive over current
> +                    events.
> +
> +- qcom,ocp-retry-delay:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: Time to delay in milliseconds between each voltage switch
> +                    toggle after an over current event takes place.

These 2 are perhaps less common. I hope I don't have a device that does this. :)

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/