linux-kernel - Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150612220616.14fdd5b7@lxorguk.ukuu.org.uk>
Date:	Fri, 12 Jun 2015 22:06:16 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	julien.dehee@...il.com, abbotti@....co.uk,
	hsweeten@...ionengravers.com, tapaswenipathak@...il.com,
	hamohammed.sa@...il.com, viro@...iv.linux.org.uk,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

On Fri, 12 Jun 2015 13:43:27 -0700
Greg KH <gregkh@...uxfoundation.org> wrote:

> On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee@...il.com wrote:
> > From: Julien Dehee <julien.dehee@...il.com>
> > 
> > comedi/comedi_fops.c
> >     use ENODEV following open manual

That should probably be ENXIO by a strict reading, but Linux has always
used ENODEV 8)

> > 
> > comedi/drivers.c
> >     use ENOTTY following ioctl manual
> > 
> > drivers/serial2002.c
> >     use ENOTTY following ioctl manual
> 
> What do you mean by "ioctl manual"?

man 2 ioctl

Unknown ioctls on a device should error with ENOTTY. It's one of
those crazy pieces of Unix history.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/