linux-kernel - Re: [PATCH V3 1/4] x86: acpi: define uncached page flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557B7008.3010502@codeaurora.org>
Date:	Fri, 12 Jun 2015 16:49:28 -0700
From:	"Zhang, Jonathan Zhixiong" <zjzhang@...eaurora.org>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Matt Fleming <matt.fleming@...el.com>, fu.wei@...aro.org,
	al.stone@...aro.org, bp@...en8.de, tony.luck@...il.com,
	ying.huang@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/4] x86: acpi: define uncached page flag



On 6/12/2015 12:52 AM, Ingo Molnar wrote:
>
> * Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org> wrote:
>
>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
>>
>> This definition is used in APEI code when needing to map pages as
>> uncached.
>>
>> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org>
>> ---
>>   arch/x86/include/asm/acpi.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/x86/include/asm/acpi.h b/arch/x86/include/asm/acpi.h
>> index 3a45668f6dc3..6afb27682b00 100644
>> --- a/arch/x86/include/asm/acpi.h
>> +++ b/arch/x86/include/asm/acpi.h
>> @@ -138,6 +138,10 @@ static inline void disable_acpi(void) { }
>>
>>   #endif /* !CONFIG_ACPI */
>>
>> +#ifdef	CONFIG_ACPI_APEI
>> +#define ARCH_APEI_PAGE_KERNEL_UC (PAGE_KERNEL_NOCACHE)
>> +#endif /*CONFIG_ACPI_APEI */
>
>   - Why the tab?
>
>   - Why the parentheses?
>
>   - Why the closing comment block for a oneliner define? It's not like we forget
>     what it's about.
>
>   - When the missing space in the closing comment?
>
> That's 4 uglies in 3 lines of code, wow ...
>
> Thanks,
>
> 	Ingo
>
Thank you Ingo for the review. I agree that style is important.

-- 
Jonathan (Zhixiong) Zhang
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/