linux-kernel - Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150612042906.GB10691@kroah.com>
Date:	Thu, 11 Jun 2015 21:29:06 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	balbi@...com, myungjoo.ham@...sung.com, k.kozlowski@...sung.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] extcon: Redefine the unique id of supported external
 connectors without 'enum extcon' type

On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
> This patch just redefine the unique id of supported external connectors without
> 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to
> indicate the specific external connectors like key number of input framework.
> So, I have the plan to move this definitions to following header file which
> includes the unique id of supported external connectors.
> - include/dt-bindings/extcon/extcon.h

Do we have other such fields in dt-bindings that are not enumerated
types?

What's wrong with keeping this as-is and not changing to an integer?

> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")

How is this a bugfix?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/