linux-kernel - Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557BED8C.6050406@monom.org>
Date:	Sat, 13 Jun 2015 08:45:00 +0000
From:	Daniel Wagner <wagi@...om.org>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>
CC:	daniel.wagner@...-carit.de, masami.hiramatsu.pt@...achi.com,
	namhyung@...nel.org, josh@...htriplett.org, andi@...stfloor.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling
 a trigger

On 06/12/2015 06:01 PM, Steven Rostedt wrote:
>
> Why v3 in the subject?

This patch has not changed since v3 I guess.

>
> On Mon,  8 Jun 2015 16:32:00 -0500
> Tom Zanussi <tom.zanussi@...ux.intel.com> wrote:
>
>> When a trigger is enabled, the cond flag should be set beforehand,
>> otherwise a trigger that's expecting to process a trace record
>> (e.g. one with post_trigger set) could be invoked without one.
>>
>> Likewise a trigger's cond flag should be reset after it's disabled,
>> not before.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
>> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
>
> Why is Daniel signed off by here?

I have reported the issue and send a fix for this patch

https://lkml.org/lkml/2015/4/21/161

I would have complained if I wasn't okay with it.

cheers,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/