linux-kernel - [BUG ?] staging: rtl8723au: condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1434191497-5611-1-git-send-email-hofrat@osadl.org>
Date:	Sat, 13 Jun 2015 12:31:37 +0200
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Roberta Dobrescu <roberta.dobrescu@...il.com>,
	Joe Perches <joe@...ches.com>,
	Daniele Alessandrelli <daniele.alessandrelli@...il.com>,
	Aleh Suprunovich <br@...amon.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Nicholas Mc Guire <hofrat@...dl.org>
Subject: [BUG ?] staging: rtl8723au: condition with no effect

scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
	WARNING: condition with no effect (if branch == else)

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7
1395    if (bWithoutHWSM) {
1396            /* value16 |= (APDM_HOST | FSM_HSUS |/PFM_ALDN); */
1397            /*  2010/08/31 According to Filen description, we need to
1398                use HW to shut down 8051 automatically. */
1399            /*  Because suspend operation need the asistance of 8051
1400                to wait for 3ms. */
1401            value16 = APDM_HOST | AFSM_HSUS | PFM_ALDN;
1402    } else {
1403            value16 = APDM_HOST | AFSM_HSUS | PFM_ALDN;
1404    }
1405 
1406    rtl8723au_write16(padapter, REG_APS_FSMCO, value16);    /* 0x4802 */

Not clear what the intent is but this looks like a typo/bug in the assigment
of value16 as the condition here has no effect.

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/