linux-kernel - [BUG ?] rtlwifi: rtl8723be: condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1434192211-5855-1-git-send-email-hofrat@osadl.org>
Date:	Sat, 13 Jun 2015 12:43:31 +0200
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Chaoming Li <chaoming_li@...lsil.com.cn>,
	Kalle Valo <kvalo@...eaurora.org>,
	"John W. Linville" <linville@...driver.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Randy Dunlap <rdunlap@...radead.org>,
	Masanari Iida <standby24x7@...il.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [BUG ?] rtlwifi: rtl8723be: condition with no effect

From: Nicholas Mc Guire <hofrat@...dl.org>                                      

scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
	WARNING: condition with no effect (if branch == else)

Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'

drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
886         if (thermalvalue > rtlefuse->eeprom_thermalmeter)                  
887                 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
888						 	index_for_channel);
889         else
890                 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
891							index_for_channel);

Can't figure out what the intent of this condition is but it currently has
no effect as if == else and this most likely is not the intent.

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/