linux-kernel - Re: [PATCH] staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150613000515.GA20155@kroah.com>
Date:	Fri, 12 Jun 2015 17:05:15 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	driverdev-devel@...uxdriverproject.org,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: cb_pcimdas: fix handlers for DI and DO
 subdevices

On Fri, Jun 12, 2015 at 04:37:41PM +0100, Ian Abbott wrote:
> Normally, low-level Comedi drivers set an `insn_bits` handler for
> digital input (DI), digital output (DO) and digital input/output (DIO)
> subdevice types to handle normal reading and writing of digital
> channels.  The "cb_pcimdas" driver currently has an `insn_read` handler
> for the DI subdevice and an `insn_write` handler for the DO subdevice.
> However, the actual handler functions `cb_pcimdas_di_insn_read()` and
> `cb_pcimdas_do_insn_write()` are written to behave like `insn_bits`
> handlers.  Something's wrong there!  To fix it, set the functions as
> `insn_bits` handlers and rename them for consistency.
> 
> Fixes: e56d03dee14a ("staging: comedi: cb_pcimdas: add main connector digital input/output")
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> ---
> I left the "Fixes:" line non-line-wrapped.  Is that the correct thing to
> do?

Sure, that's fine, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/