linux-kernel - Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <195F4F7A-2206-40D5-BD45-BACD61E81C8F@163.com>
Date:	Sat, 13 Jun 2015 10:52:24 +0800
From:	pi3orama <pi3orama@....com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Wang Nan <wangnan0@...wei.com>,
	"acme@...nel.org" <acme@...nel.org>,
	"brendan.d.gregg@...il.com" <brendan.d.gregg@...il.com>,
	"daniel@...earbox.net" <daniel@...earbox.net>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"masami.hiramatsu.pt@...achi.com" <masami.hiramatsu.pt@...achi.com>,
	"paulus@...ba.org" <paulus@...ba.org>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"dsahern@...il.com" <dsahern@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lizefan@...wei.com" <lizefan@...wei.com>,
	"hekuang@...wei.com" <hekuang@...wei.com>,
	"xiakaixu@...wei.com" <xiakaixu@...wei.com>
Subject: Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options



发自我的 iPhone

> 在 2015年6月13日，上午10:31，Alexei Starovoitov <ast@...mgrid.com> 写道：
> 
>> On 6/11/15 10:35 PM, Wang Nan wrote:
>>         # Path to clang. If omit, search it from $PATH.
>>    clang-path = "/path/to/clang"
> 
> I think this bit and search_program() from the next patch is
> overly flexible. It's always delicate to search file paths.
> Unless this is really needed, I would drop this bit.

I think searching clang before execution is still equired. If not, we are unable to know the exact reason why the shell script failed. If there's no clang at all, we can simply return an error instead of trying to detect kbuild and kernel header. Which is slower than clang compiling itself.

What about creating another shell script simply run 'clang --version' to check availability of clang? Then search_program can be dropped.

Thank you.

> popen() in the next patch executes clang via shell,
> so explicit PATH search in unnecessary.
> 
> The rest of the patches look good to me.
> Thanks again.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/