linux-kernel - Re: [PATCH 05/12] mm: Introduce arch_pgd_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150613065424.GA16745@gmail.com>
Date:	Sat, 13 Jun 2015 08:54:24 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mml@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Waiman Long <Waiman.Long@...com>
Subject: Re: [PATCH 05/12] mm: Introduce arch_pgd_init_late()


* Oleg Nesterov <oleg@...hat.com> wrote:

> On 06/11, Ingo Molnar wrote:
> >
> > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags,
> >  	syscall_tracepoint_update(p);
> >  	write_unlock_irq(&tasklist_lock);
> >  
> > +	/*
> > +	 * If we have a new PGD then initialize it:
> > +	 *
> > +	 * This method is called after a task has been made visible
> > +	 * on the task list already.
> > +	 *
> > +	 * Architectures that manage per task kernel pagetables
> > +	 * might use this callback to initialize them after they
> > +	 * are already visible to new updates.
> > +	 *
> > +	 * NOTE: any user-space parts of the PGD are already initialized
> > +	 *       and must not be clobbered.
> > +	 */
> > +	if (p->mm != current->mm)
> > +		arch_pgd_init_late(p->mm, p->mm->pgd);
> > +
> 
> Cosmetic, but imo
> 
> 	if (!(clone_flags & CLONE_VM))
> 		arch_pgd_init_late(...);
> 
> will look better and more consistent.

Indeed - fixed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/