linux-kernel - [PATCH 1/1] pcmcia: Add missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Jun 2015 21:14:41 +0900
From:	Takeshi Yoshimura <yos@...ab.ics.keio.ac.jp>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vaishali Thakkar <vthakkar1994@...il.com>,
	linux-pcmcia@...ts.infradead.org
Cc:	linux-kernel@...r.kernel.org,
	Takeshi Yoshimura <yos@...ab.ics.keio.ac.jp>
Subject: [PATCH 1/1] pcmcia: Add missing free_irq()

In yenta_probe(), an irq leak potentially happens when
pcmcia_register_socket() fails. I added the missed call.

Signed-off-by: Takeshi Yoshimura <yos@...ab.ics.keio.ac.jp>
---
 drivers/pcmcia/yenta_socket.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index 965bd84..7922e30f 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -1269,6 +1269,8 @@ static int yenta_probe(struct pci_dev *dev, const struct pci_device_id *id)
 		pcmcia_unregister_socket(&socket->socket);
 	}
 
+	if (socket->cb_irq)
+		free_irq(socket->irq, socket);
  unmap:
 	iounmap(socket->base);
  release:
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/