linux-kernel - Re: [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Jun 2015 18:59:28 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	Igor Vuk <parcijala@...il.com>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	brouer@...hat.com
Subject: Re: [PATCH] pktgen: fix typos in
 pktgen_bench_xmit_mode_netif_receive.sh

On Sun, 14 Jun 2015 11:43:38 +0200
Igor Vuk <parcijala@...il.com> wrote:

> Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh,
> also does some minor reformatting so the original layout is
> preserved.
> 
> Signed-off-by: Igor Vuk <parcijala@...il.com>
> ---
>  samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> index cb15903..a25525e 100755
> --- a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> +++ b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> @@ -7,9 +7,9 @@
>  # "xmit_mode netif_receive".  With an invalid dst_mac this will only
>  # measure the ingress code path as packets gets dropped in ip_rcv().
>  #
> -# This script don't really need any hardware.  It benchmarks software
> -# RX path just after NIC driver level.  With bursting is also
> -# "removes" the SKB alloc/free overhead.
> +# This script doesn't really need any hardware.  It benchmarks
> +# software RX path just after NIC driver level.  With bursting it
> +# also "removes" the SKB alloc/free overhead.
>  #
>  # Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
>  # ------------------------------------------------------------------
> @@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
>      # Inject packet into RX path of stack
>      pg_set $dev "xmit_mode netif_receive"
>  
> -    # Burst allow us to avoid measuring SKB alloc/free overhead
> +    # Burst allows us to avoid measuring SKB alloc/free overhead
>      pg_set $dev "burst $BURST"

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/