linux-kernel - Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150614193755.GA13291@light.dominikbrodowski.net>
Date:	Sun, 14 Jun 2015 21:37:55 +0200
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Takeshi Yoshimura <yos@...ab.ics.keio.ac.jp>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vaishali Thakkar <vthakkar1994@...il.com>,
	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and
 _close()

On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote:
> There are some resource leaks in yenta_probe() and _close(). I fixed
> the following issues with some code cleanups. Thanks to Dominik's
> suggestions.
> 
> On the error path in yenta_probe():
> - a requested irq is not released
> - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called
> 
> In yenta_close():
> - kfree(sock) is not called
> - sock->base is always set to non-NULL when yenta_close() is called,
>   therefore the check in yenta_close() is not necessary.
> 
> Signed-off-by: Takeshi Yoshimura <yos@...ab.ics.keio.ac.jp>

Applied to the PCMCIA tree. Many thanks!

	Dominik

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)