linux-kernel - RE: [char-misc-next 02/17] mei: bus: fix drivers and devices names confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B3D3C28C5@hasmsx108.ger.corp.intel.com>
Date:	Sun, 14 Jun 2015 06:30:13 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [char-misc-next 02/17] mei: bus: fix drivers and devices names
 confusion



> 
> On Sat, Jun 13, 2015 at 10:11:34PM +0300, Tomas Winkler wrote:
> > the variables of type mei_cl_device are now cldev
> > the variables of type mei_cl_driver are now cldrv
> 
> You are saying what you did, but not why you are doing it.  Renaming
> variables for no good reason means I have to reject this patch, sorry.

The reason is in title of this commit: "fix drivers and devices names confusion" 
> 
> > the variables of type mei_device are now bus in the
> > bus layer context
> 
> What do you mean by this?

mei_device plays bus role in this context so to make it clear I call the variable 'bus'

Thanks
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/