linux-kernel - Re: [PATCH v2 13/17] x86/tsc: Rename native_read_tsc() to rdtsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150614115407.GA14896@pd.tnic>
Date:	Sun, 14 Jun 2015 13:54:08 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	John Stultz <john.stultz@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Len Brown <lenb@...nel.org>, Huang Rui <ray.huang@....com>,
	Denys Vlasenko <dvlasenk@...hat.com>
Subject: Re: [PATCH v2 13/17] x86/tsc: Rename native_read_tsc() to
 rdtsc_unordered()

On Sat, Jun 13, 2015 at 11:25:49AM -0700, Andy Lutomirski wrote:
> I could go either way here.  rdtsc() is weird because people seem to
> forget about the barrier.

Yeah, our job is only to give them enough rope...

> Maybe I'm being unnecessarily paranoid.

You can always slap a comment above the rdtsc() definition saying that
people should use the _ordered() version if they wanna order. :)

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/