linux-kernel - Re: [PATCH 1/1 linux-next] mmc: queue: use swap() in mmc_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2015 11:54:32 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] mmc: queue: use swap() in mmc_queue_thread()

On 10 June 2015 at 18:30, Fabian Frederick <fabf@...net.be> wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Thanks, applied.

Kind regards
Uffe

> ---
>  drivers/mmc/card/queue.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
> index 8efa368..d34e09b 100644
> --- a/drivers/mmc/card/queue.c
> +++ b/drivers/mmc/card/queue.c
> @@ -56,7 +56,6 @@ static int mmc_queue_thread(void *d)
>         down(&mq->thread_sem);
>         do {
>                 struct request *req = NULL;
> -               struct mmc_queue_req *tmp;
>                 unsigned int cmd_flags = 0;
>
>                 spin_lock_irq(q->queue_lock);
> @@ -86,9 +85,7 @@ static int mmc_queue_thread(void *d)
>
>                         mq->mqrq_prev->brq.mrq.data = NULL;
>                         mq->mqrq_prev->req = NULL;
> -                       tmp = mq->mqrq_prev;
> -                       mq->mqrq_prev = mq->mqrq_cur;
> -                       mq->mqrq_cur = tmp;
> +                       swap(mq->mqrq_prev, mq->mqrq_cur);
>                 } else {
>                         if (kthread_should_stop()) {
>                                 set_current_state(TASK_RUNNING);
> --
> 2.4.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/