linux-kernel - Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150615133810.GA19996@pengutronix.de>
Date:	Mon, 15 Jun 2015 15:38:10 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Kevin Hilman <khilman@...aro.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	linux-arm-msm@...r.kernel.org, Kumar Gala <galak@...eaurora.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Andy Gross <agross@...eaurora.org>,
	Lina Iyer <lina.iyer@...aro.org>
Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that
 resume in ARM state

Hello Russell,

On Mon, Jun 15, 2015 at 12:01:36PM +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 15, 2015 at 08:33:25AM +0200, Uwe Kleine-König wrote:
> > Hello,
> > > +	.arm
> > > +ENTRY(cpu_resume_arm)
> > > + THUMB(	badr	r9, 1f		)	@ Kernel is entered in ARM.
> > > + THUMB(	bx	r9		)	@ If this is a Thumb-2 kernel,
> > > + THUMB(	.thumb			)	@ switch to Thumb now.
> > > + THUMB(1:			)
> > >  ENTRY(cpu_resume)
> > >  ARM_BE8(setend be)			@ ensure we are in BE mode
> > >  #ifdef CONFIG_ARM_VIRT_EXT
> > this patch is in next as 51ac91b7f6b11b0da55ac93885ee7b864865bcb1 and
> > breaks efm32_defconfig. The exact error message is:
> > 
> >   AS      arch/arm/kernel/sleep.o
> > arch/arm/kernel/sleep.S: Assembler messages:
> > arch/arm/kernel/sleep.S:121: Error: selected processor does not support ARM opcodes
> > arch/arm/kernel/sleep.S:123: Error: bad instruction `badr r9,1f'
> > arch/arm/kernel/sleep.S:124: Error: attempt to use an ARM instruction on a Thumb-only processor -- `bx r9'
> > scripts/Makefile.build:294: recipe for target 'arch/arm/kernel/sleep.o' failed
> > make[3]: *** [arch/arm/kernel/sleep.o] Error 1
> 
> Don't get me wrong, the build testing which goes on is really great, but
> there's now a problem with all this.
> 
> There needs to be coordination between the people doing the build tests
> to ensure that we don't "tire out" those who read the emails with different
> groups of people reporting the same problem days after it was first
> discovered, and even worse, days after it's been fixed.
> 
> The worst thing to do is to report build regressions on Monday for a tree
> which was created on Thursday - by the time Monday comes around, projects
> such as the 0-day builder have had plenty of time to find them.
> 
> Remember, the linux-next tree which is published on Friday (Austrailian
> time) is a result of git trees snapshotted around midnight on Thursday.
> 
> So, if you're going to build an old linux-next tree, before you report any
> problems, please check whether other build systems have already reported
> them.  If you've gone to the trouble of tracking down the commit which
> caused it, and therefore the likely git tree, check whether a fix has
> already been merged.  Or maybe wait until the post-weekend linux-next is
> published...
> 
> (The problem you're referring to was fixed and pushed out on Friday -
> which seems to be a regular thing that happens with problems you've
> reported on Mondays...)
I consulted Google (asking for the commit id) and checked the
linux-arm-kernel list for reports which usually works well enough.

But I understand your complaint, last time I introduced a build
regression I got two automatic reports and three times the same fix into
my mailbox. So I will try to be more careful in the future.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/