linux-kernel - Re: [PATCH 5/5] serial/8250_fintek: Support for any io address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_2T2wzbfE2y8aYbhrAYoUEafY8di+YasCLNXSwe+CN-Kw@mail.gmail.com>
Date:	Mon, 15 Jun 2015 17:22:03 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Peter Huewe <PeterHuewe@....de>, linux-serial@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Peter H <peter_hong@...tek.com.tw>
Subject: Re: [PATCH 5/5] serial/8250_fintek: Support for any io address.

Hello Alan

On Mon, Jun 15, 2015 at 4:25 PM, Alan Cox <alan@...ux.intel.com> wrote:

>
> Please however fix the dynamic on stack arrays you've got. Doing
>
>         blah foo[] = { 1,2,3,4 };
>
> might well be valid gcc but it generates horrible code when in fact your
> arrays should be static/const, not dynamically constructed on stack from
> a static copy each call.

Thanks for the comments, I have resubmitted the patchset.

>
> Reviewed-by: Alan Cox <alan@...ux.intel.com>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/