linux-kernel - RE: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03CA77BA8AF6F1469AEDFBDA1322A7B7495B1048@XAP-PVEXMBX02.xlnx.xilinx.com>
Date:	Mon, 15 Jun 2015 16:04:25 +0000
From:	Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>
To:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
CC:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"kpc528@...il.com" <kpc528@...il.com>,
	"kalluripunnaiahchoudary@...il.com" 
	<kalluripunnaiahchoudary@...il.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support



> -----Original Message-----
> From: Shubhrajyoti Datta [mailto:omaplinuxkernel@...il.com]
> Sent: Monday, June 15, 2015 8:35 PM
> To: Punnaiah Choudary Kalluri
> Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com;
> ijc+devicetree@...lion.org.uk; Kumar Gala; Michal Simek; Soren Brinkmann;
> vinod.koul@...el.com; dan.j.williams@...el.com;
> devicetree@...r.kernel.org; Linux Kernel Mailing List; kpc528@...il.com;
> kalluripunnaiahchoudary@...il.com; dmaengine@...r.kernel.org;
> Punnaiah Choudary Kalluri; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver
> support
> 
> On Mon, Jun 15, 2015 at 8:06 PM, Punnaiah Choudary Kalluri
> <punnaiah.choudary.kalluri@...inx.com> wrote:
> > Added the basic driver for zynqmp dma engine used in Zynq
> > UltraScale+ MPSoC. The initial release of this driver supports
> > only memory to memory transfers.
> >
> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@...inx.com>
> > ---
> <snip>
> 
> > +/**
> > + * zynqmp_dma_chan_is_idle - Provides the channel idle status
> > + * @chan: ZynqMP DMA DMA channel pointer
> > + *
> > + * Return: '1' if the channel is idle otherwise '0'
> > + */
> > +static int zynqmp_dma_chan_is_idle(struct zynqmp_dma_chan *chan)
> 
> maybe this could return bool.

Ok. I will modify the return type.

Regards,
Punnaiah
> 
> > +{
> > +       u32 regval;
> > +
> > +       regval = readl(chan->regs + STATUS);
> > +       if (regval & STATUS_BUSY)
> > +               return 0;
> > +
> > +       return 1;
> > +}
> > +