linux-kernel - Re: [PATCH ljones-mfd] mfd: cros_ec:: ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <557F224F.7090102@collabora.co.uk>
Date:	Mon, 15 Jun 2015 21:06:55 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	kbuild test robot <fengguang.wu@...el.com>,
	Gwendal Grignou <gwendal@...omium.org>
CC:	kbuild-all@...org, Lee Jones <lee.jones@...aro.org>,
	Dmitry Torokhov <dtor@...omium.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH ljones-mfd] mfd: cros_ec:: ec_p can be static

Hello Fengguang,

Thanks a lot for your patch.

On 06/15/2015 03:39 PM, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  cros_ec.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 11b1884b..dd6f4ff 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -27,7 +27,7 @@
>  #define CROS_EC_DEV_EC_INDEX 0
>  #define CROS_EC_DEV_PD_INDEX 1
>  
> -struct cros_ec_platform ec_p = {
> +static struct cros_ec_platform ec_p = {
>  	.ec_name = CROS_EC_DEV_NAME,
>  	.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_EC_INDEX),
>  };
> @@ -37,13 +37,13 @@ struct cros_ec_platform pd_p = {
>  	.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX),
>  };

This can also be static

>  
> -struct mfd_cell ec_cell = {
> +static struct mfd_cell ec_cell = {
>  	.name = "cros-ec-ctl",
>  	.platform_data = &ec_p,
>  	.pdata_size = sizeof(ec_p),
>  };
>  
> -struct mfd_cell ec_pd_cell = {
> +static struct mfd_cell ec_pd_cell = {
>  	.name = "cros-ec-ctl",
>  	.platform_data = &pd_p,
>  	.pdata_size = sizeof(pd_p),
> 

These two should in fact be static const since mfd_add_devices()
expects a const struct mfd_cell * as third argument. I forgot on
my patch, sorry about that.

With these changes:

Acked-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/