linux-kernel - Re: [PATCH 1/1] Add timer_32k_ck alias for dm816x in clk-816x.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <557F29A6.8040109@ti.com>
Date:	Mon, 15 Jun 2015 22:38:14 +0300
From:	Tero Kristo <t-kristo@...com>
To:	Brian Hutchinson <b.hutchman@...il.com>, <mturquette@...aro.org>,
	<sboyd@...eaurora.org>
CC:	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<paul@...an.com>, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH 1/1] Add timer_32k_ck alias for dm816x in clk-816x.c

Subject should have clk: ti: in the beginning.

On 06/15/2015 09:54 PM, Brian Hutchinson wrote:
> dm816x needs timer_32k_ck alias to use dual mode timers in dmtimers.c
>
> This adds a timer_32k_ck alias for sys_32_ck in clk-816x.c so
> omap_dm_timer_set_source will work for dm816x.

Use checkpatch please. Or use a mailer that doesn't convert tabs to 
spaces. This patch seems to have something else that is strange also.

>
> Cc: Paul Walmsley <paul@...an.com <mailto:paul@...an.com>>
> Cc: Tero Kristo <t-kristo@...com <mailto:t-kristo@...com>>
> Cc: Tony Lindgren <tony@...mide.com <mailto:tony@...mide.com>>
> Signed-off-by: Brian Hutchinson <b.hutchman@...il.com
> <mailto:b.hutchman@...il.com>>
>
> --- drivers/clk/ti/clk-816x.c_orig      2015-06-15 13:46:53.058128064 -0400
> +++ drivers/clk/ti/clk-816x.c   2015-06-15 13:47:28.966306123 -0400

What is that _orig here? Are you using git to generate the patches?

-Tero

> @@ -18,6 +18,7 @@ static struct ti_dt_clk dm816x_clks[] =
>          DT_CLK(NULL, "sys_clkin", "sys_clkin_ck"),
>          DT_CLK(NULL, "timer_sys_ck", "sys_clkin_ck"),
>          DT_CLK(NULL, "sys_32k_ck", "sys_32k_ck"),
> +       DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"),
>          DT_CLK(NULL, "mpu_ck", "mpu_ck"),
>          DT_CLK(NULL, "timer1_fck", "timer1_fck"),
>          DT_CLK(NULL, "timer2_fck", "timer2_fck"),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/