linux-kernel - Re: Possible broken MM code in dell-laptop.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2015 13:36:45 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Hans de Goede <hdegoede@...hat.com>,
	Ben Skeggs <bskeggs@...hat.com>,
	Stuart Hayes <stuart_hayes@...l.com>,
	Matthew Garrett <mjg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	platform-driver-x86@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: Possible broken MM code in dell-laptop.c?

On Sun, Jun 14, 2015 at 11:05:07AM +0200, Pali Rohár wrote:
> Hello,
> 
> in drivers/platform/x86/dell-laptop.c is this part of code:
> 
> static int __init dell_init(void)
> {
> ...
> 	/*
> 	 * Allocate buffer below 4GB for SMI data--only 32-bit physical addr
> 	 * is passed to SMI handler.
> 	 */
> 	bufferpage = alloc_page(GFP_KERNEL | GFP_DMA32);
> 	if (!bufferpage) {
> 		ret = -ENOMEM;
> 		goto fail_buffer;
> 	}
> 	buffer = page_address(bufferpage);
> 
> 	ret = dell_setup_rfkill();
> 
> 	if (ret) {
> 		pr_warn("Unable to setup rfkill\n");
> 		goto fail_rfkill;
> 	}
> ...
> fail_rfkill:
> 	free_page((unsigned long)bufferpage);
> fail_buffer:
> ...
> }
> 
> Then there is another part:
> 
> static void __exit dell_exit(void)
> {
> ...
> 	free_page((unsigned long)buffer);

I believe you are correct, and this should be bufferpage. Have you observed any
failures?

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/