linux-kernel - RE: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux proc num onto Hyper-V proc num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM2PR0301MB123258F63DE2BC6F4E1F3BCAABB80@DM2PR0301MB1232.namprd03.prod.outlook.com>
Date:	Mon, 15 Jun 2015 21:23:50 +0000
From:	Jake Oshins <jakeo@...rosoft.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	KY Srinivasan <kys@...rosoft.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Mike Ebersol <Michael.Ebersol@...rosoft.com>
Subject: RE: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux proc
 num onto Hyper-V proc num



> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Monday, June 15, 2015 12:52 PM
> To: Jake Oshins
> Cc: KY Srinivasan; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> vkuznets@...hat.com; bhelgaas@...gle.com; linux-pci@...r.kernel.org;
> pebolle@...cali.nl; Haiyang Zhang; Mike Ebersol
> Subject: Re: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux
> proc num onto Hyper-V proc num
> 
> > +/**
> > + * This function returns the mapping between the Linux processor
> > + * number and
> > + * the hypervisor's virtual processor number, useful in making
> > + * hypercalls and such that talk about specific processors.
> > + *
> > + * @param procnum - in Linux terms
> 
> What kind of comment structure is this?  It's not kernel doc :(
> 
> And "procnum" sounds like "process number", why not "cpu_number"?

Thanks.  I'll wait a little while to see if any other feedback comes in and then I'll fix these and resend.

-- Jake Oshins

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/