lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150615213332.GC6458@krava.redhat.com>
Date:	Mon, 15 Jun 2015 23:33:32 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 03/30] perf tools: Change thread_map::map into struct

On Mon, Jun 15, 2015 at 04:04:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jun 14, 2015 at 10:19:18AM +0200, Jiri Olsa escreveu:
> > We need to store command names with the pid. Changing
> > map to be struct holding pid. Process name is coming
> > in shortly.
> 
> <SNIP>
>  
> > +++ b/tools/perf/util/thread_map.h
> > @@ -4,11 +4,17 @@
> >  #include <sys/types.h>
> >  #include <stdio.h>
> >  
> > +struct thread_map_data {
> > +	pid_t    pid;
> > +};
> > +
> 
> What 'data' is this? That is way vague term.

data related to thread_mmap ;-)

jirka

> 
>  Will try looking at the other patches to try to suggest some other name
> for this :-\
> 
> >  struct thread_map {
> >  	int nr;
> > -	pid_t map[];
> > +	struct thread_map_data map[];
> >  };
> >  
> > +#define thread_map__pid(__m, __t)  __m->map[__t].pid
> > +
> >  struct thread_map *thread_map__new_dummy(void);
> >  struct thread_map *thread_map__new_by_pid(pid_t pid);
> >  struct thread_map *thread_map__new_by_tid(pid_t tid);
> > -- 
> > 1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ