lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jun 2015 10:38:57 +0530 From: Vinod Koul <vinod.koul@...el.com> To: Rasmus Villemoes <linux@...musvillemoes.dk> Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, yang.a.fang@...el.com Subject: Re: [PATCH] ASoC: Intel: mrfld: simplify sst_fill_widget_module_info On Thu, Jun 04, 2015 at 10:13:53AM +0200, Rasmus Villemoes wrote: > Some tiny improvements, cutting 180 bytes off the generated code. > > - use strchr() for single-character needle > > - compute index using pointer subtraction instead of two strlen() > calls > > - factor out the common check for whether the initial part of > kctl->id.name (before the space) is identical to w->name. Acked-by: Vinod Koul <vinod.koul@...el.com Also Terry did the tests on this patch so would be good to add Tested-by: Fang, Yang A <yang.a.fang@...el.com> -- ~Vinod > > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk> > --- > sound/soc/intel/atom/sst-atom-controls.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c > index 90aa5c0476f3..16670feeee6a 100644 > --- a/sound/soc/intel/atom/sst-atom-controls.c > +++ b/sound/soc/intel/atom/sst-atom-controls.c > @@ -1280,36 +1280,32 @@ static int sst_fill_widget_module_info(struct snd_soc_dapm_widget *w, > down_read(&card->controls_rwsem); > > list_for_each_entry(kctl, &card->controls, list) { > - idx = strstr(kctl->id.name, " "); > + idx = strchr(kctl->id.name, ' '); > if (idx == NULL) > continue; > - index = strlen(kctl->id.name) - strlen(idx); > + index = idx - (char*)kctl->id.name; > + if (strncmp(kctl->id.name, w->name, index)) > + continue; > > - if (strstr(kctl->id.name, "Volume") && > - !strncmp(kctl->id.name, w->name, index)) > + if (strstr(kctl->id.name, "Volume")) > ret = sst_fill_module_list(kctl, w, SST_MODULE_GAIN); > > - else if (strstr(kctl->id.name, "params") && > - !strncmp(kctl->id.name, w->name, index)) > + else if (strstr(kctl->id.name, "params")) > ret = sst_fill_module_list(kctl, w, SST_MODULE_ALGO); > > else if (strstr(kctl->id.name, "Switch") && > - !strncmp(kctl->id.name, w->name, index) && > strstr(kctl->id.name, "Gain")) { > struct sst_gain_mixer_control *mc = > (void *)kctl->private_value; > > mc->w = w; > > - } else if (strstr(kctl->id.name, "interleaver") && > - !strncmp(kctl->id.name, w->name, index)) { > + } else if (strstr(kctl->id.name, "interleaver")) { > struct sst_enum *e = (void *)kctl->private_value; > > e->w = w; > > - } else if (strstr(kctl->id.name, "deinterleaver") && > - !strncmp(kctl->id.name, w->name, index)) { > - > + } else if (strstr(kctl->id.name, "deinterleaver")) { > struct sst_enum *e = (void *)kctl->private_value; > > e->w = w; > -- > 2.1.3 > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists