linux-kernel - Re: [PATCH] Staging: lusture: Remove an open coded simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14E04FD4-9283-406C-A5D2-68B27DF58F5F@intel.com>
Date:	Tue, 16 Jun 2015 07:07:38 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"HPDD-discuss@...ts.01.org" <HPDD-discuss@...ts.01.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ravindran, Madhusudhanan (M.)" <mravindr@...teon.com>,
	"Dighe, Niranjan (N.)" <ndighe@...teon.com>
Subject: Re: [PATCH] Staging: lusture: Remove an open coded simple_open()
 function 


On Jun 16, 2015, at 3:03 AM, Abdul, Hussain (H.) wrote:

> From: Abdul Hussain <habdul@...teon.com>
> 
> This patch removes an open coded simple_open() function and replace file
> operations references to the function with simple_open() instead
> 
> Signed-off-by: Abdul Hussain <habdul@...teon.com>
> ---
> drivers/staging/lustre/lustre/fld/lproc_fld.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> index b35ff28..d19b724 100644
> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> @@ -143,13 +143,6 @@ fld_debugfs_cache_flush_write(struct file *file, const char __user *buffer,
> }
> 
> static int
> -fld_debugfs_cache_flush_open(struct inode *inode, struct file *file)
> -{
> -	file->private_data = inode->i_private;
> -	return 0;
> -}
> -
> -static int
> fld_debugfs_cache_flush_release(struct inode *inode, struct file *file)
> {
> 	file->private_data = NULL;
> @@ -158,7 +151,7 @@ fld_debugfs_cache_flush_release(struct inode *inode, struct file *file)
> 
> static struct file_operations fld_debugfs_cache_flush_fops = {
> 	.owner		= THIS_MODULE,
> -	.open		= fld_debugfs_cache_flush_open,
> +	.open = simple_open,

Could you please save the indenting to match the rest of this structure assignment?

> 	.write		= fld_debugfs_cache_flush_write,
> 	.release	= fld_debugfs_cache_flush_release,
> };
> -- 
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/