linux-kernel - Re: [PATCH 3.4 051/172] netfilter: xt_socket: fix a stack corruption bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150616102344.GC3591@salvia>
Date:	Tue, 16 Jun 2015 12:23:44 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	lizf@...nel.org
Cc:	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>,
	Zefan Li <lizefan@...wei.com>
Subject: Re: [PATCH 3.4 051/172] netfilter: xt_socket: fix a stack corruption
 bug

On Tue, Jun 16, 2015 at 04:35:05PM +0800, lizf@...nel.org wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> 3.4.108-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> 
> commit 78296c97ca1fd3b104f12e1f1fbc06c46635990b upstream.
> 
> As soon as extract_icmp6_fields() returns, its local storage (automatic
> variables) is deallocated and can be overwritten.
> 
> Lets add an additional parameter to make sure storage is valid long
> enough.
> 
> While we are at it, adds some const qualifiers.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: b64c9256a9b76 ("tproxy: added IPv6 support to the socket match")
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> [lizf: Backported to 3.4: adjust context]
> Signed-off-by: Zefan Li <lizefan@...wei.com>

Thanks for backporting this for 3.4.

Acked-by: Pablo Neira Ayuso <pablo@...filter.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/