linux-kernel - Re: [PATCH v2 4/4] sched:Use correct nid while evaluating task weights

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150616172639.GB1976@linux.vnet.ibm.com>
Date:	Tue, 16 Jun 2015 22:56:39 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Rik van Riel <riel@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH v2 4/4] sched:Use correct nid while evaluating task
 weights

* Rik van Riel <riel@...hat.com> [2015-06-16 11:00:18]:

> On 06/16/2015 07:56 AM, Srikar Dronamraju wrote:
> > In task_numa_migrate(), while evaluating other nodes for group
> > consolidation, env.dst_nid is used instead of using the iterator nid.
> > Using env.dst_nid would mean dist is always the same. Infact the same
> > dist was calculated above while evaluating the preferred node.
> > 
> > Fix the above to use the iterator nid.
> 
> Good catch.
> 
> > Also the task/group weights from the src_nid should be calculated
> > irrespective of numa topology type.
> 
> If you look at score_nearby_nodes(), you will see that
> maxdist is only used when the topology is NUMA_BACKPLANE.
> 
> The source score never changes when having a directly
> connected or NUMA_GLUELESS_MESH type system, so the source
> score does not need to be recalculated unless we are actually
> dealing with a NUMA_BACKPLANE topology.
> 
> Looking forward to a v2 with just the first fix.

Okay, will fix accordingly.

-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/