linux-kernel - Re: [PATCH] Input: pixcir_i2c_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150616220743.GB17610@dtor-ws>
Date:	Tue, 16 Jun 2015 15:07:43 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Frodo Lai <frodo.lai@...il.com>
Cc:	rogerq@...com, rydberg@...math.org, jg1.han@...sung.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: pixcir_i2c_ts - fix receive error

On Tue, Jun 16, 2015 at 01:03:04PM -0700, Frodo Lai wrote:
> The i2c_master_recv() uses readsize to receive data from i2c but
> compares to size of rdbuf which is always 27. This would casue
> problem when the max_fingers is not 5. Change the comparison value
> to readsize instead.
> 
> Signed-off-by: Frodo Lai <frodo_lai@...com.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/pixcir_i2c_ts.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 2c21071..8f3e243 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
>  	}
>  
>  	ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
> -	if (ret != sizeof(rdbuf)) {
> +	if (ret != readsize) {
>  		dev_err(&tsdata->client->dev,
>  			"%s: i2c_master_recv failed(), ret=%d\n",
>  			__func__, ret);
> -- 
> 1.7.9.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/