lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Jun 2015 16:03:57 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Andy Lutomirski <luto@...nel.org> Cc: x86@...nel.org, Borislav Petkov <bp@...e.de>, Peter Zijlstra <peterz@...radead.org>, John Stultz <john.stultz@...aro.org>, linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>, Huang Rui <ray.huang@....com>, Denys Vlasenko <dvlasenk@...hat.com>, linux-input@...r.kernel.org Subject: Re: [PATCH v2 10/17] input/joystick/analog: Switch from rdtscl() to native_read_tsc() On Fri, Jun 12, 2015 at 04:44:50PM -0700, Andy Lutomirski wrote: > This timing code is hideous, and this doesn't help. It gets rid of > one of the last users of rdtscl, though. > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com> > Cc: linux-input@...r.kernel.org > Signed-off-by: Andy Lutomirski <luto@...nel.org> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com> > --- > drivers/input/joystick/analog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c > index 4284080e481d..f871b4f00056 100644 > --- a/drivers/input/joystick/analog.c > +++ b/drivers/input/joystick/analog.c > @@ -143,7 +143,7 @@ struct analog_port { > > #include <linux/i8253.h> > > -#define GET_TIME(x) do { if (cpu_has_tsc) rdtscl(x); else x = get_time_pit(); } while (0) > +#define GET_TIME(x) do { if (cpu_has_tsc) x = (unsigned int)native_read_tsc(); else x = get_time_pit(); } while (0) > #define DELTA(x,y) (cpu_has_tsc ? ((y) - (x)) : ((x) - (y) + ((x) < (y) ? PIT_TICK_RATE / HZ : 0))) > #define TIME_NAME (cpu_has_tsc?"TSC":"PIT") > static unsigned int get_time_pit(void) > @@ -160,7 +160,7 @@ static unsigned int get_time_pit(void) > return count; > } > #elif defined(__x86_64__) > -#define GET_TIME(x) rdtscl(x) > +#define GET_TIME(x) do { x = (unsigned int)native_read_tsc(); } while (0) > #define DELTA(x,y) ((y)-(x)) > #define TIME_NAME "TSC" > #elif defined(__alpha__) || defined(CONFIG_MN10300) || defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_TILE) > -- > 2.4.2 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists