linux-kernel - Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150617062743.GA18998@redhat.com>
Date:	Wed, 17 Jun 2015 08:28:14 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	davem@...emloft.net, willemb@...gle.com, al.drozdov@...il.com,
	viro@...iv.linux.org.uk, eyal.birger@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	pankaj.m@...sung.com
Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

On Wed, Jun 17, 2015 at 10:06:01AM +0530, Maninder Singh wrote:
> Use BUG_ON(condition) instead of if(condition)/BUG() .
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@...sung.com>

Why not?

Acked-by: Michael S. Tsirkin <mst@...hat.com>


> ---
>  net/packet/af_packet.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index b5989c6..c91d405 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_ring)
>  {
>  	struct tpacket_kbdq_core *pkc;
>  
> -	if (tx_ring)
> -		BUG();
> +	BUG_ON(tx_ring);
>  
>  	pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
>  			GET_PBDQC_FROM_RB(&po->rx_ring);
> -- 
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/