linux-kernel - Re: [PATCH 5/5] ARM64: MediaTek MT8173: Add SCPSYS device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150617075647.GG6325@pengutronix.de>
Date:	Wed, 17 Jun 2015 09:56:47 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Kevin Hilman <khilman@...nel.org>
Cc:	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	kernel@...gutronix.de, Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 5/5] ARM64: MediaTek MT8173: Add SCPSYS device node

On Tue, Jun 16, 2015 at 11:17:53AM -0700, Kevin Hilman wrote:
> Sascha Hauer <s.hauer@...gutronix.de> writes:
> 
> > This adds the SCPSYS device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 924fdb6..12430f0 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -125,6 +125,16 @@
> >  						<GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> >  		};
> >  
> > +		scpsys: scpsys@...06000 {
> > +			compatible = "mediatek,mt8173-scpsys";
> > +			#power-domain-cells = <1>;
> > +			reg = <0 0x10006000 0 0x1000>;
> > +			clocks = <&clk26m>,
> > +				 <&topckgen CLK_TOP_MM_SEL>;
> 
> Neither your binding doc (nor the generic one) mentions these clock
> properties or what they are used for.  They appear to define a clock
> that must be enabled in order to for the power domain to be on.

Ok, will add documentation for this.

> 
> Also the order here seems rather important and probably needs
> documenting in the binding (e.g. the clk_id order is hard-coded in the
> driver.)

The order is not important, the clock-names property defines which clock
is which.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/