linux-kernel - Re: [Patch v3] driver/clk/clk-si5338: Add common clock framework driver for si5338

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434533368.2069.135.camel@x220>
Date:	Wed, 17 Jun 2015 11:29:28 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	York Sun <yorksun@...escale.com>
Cc:	mturquette@...libre.com, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Andrey Filippov <andrey@...hel.com>
Subject: Re: [Patch v3] driver/clk/clk-si5338: Add common clock framework
 driver for si5338

On Tue, 2015-06-16 at 09:31 -0700, York Sun wrote:
> COMMON_CLK in Kconfig is changed from bool to tristate so all common
> clock framework drivers can be selected by users.

A bool to tristate change isn't needed to make it possible to set a
symbol manually. That's achieved by adding a prompt (which the patch
also does).

This change adds a prompt to the symbol that enables the framework. But,
as far as I can see, clock drivers depending on that framework already
can be set manually. So that's another reason the above looks incorrect
to me.

Note that the "help" of COMMON_CLK contains:
    Architectures utilizing the common struct clk should select
    this option.

Does the architecture this patch targets perhaps not select COMMON_CLK?
If that's the case, it seems you should change that architecture
instead.

> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig

>  config COMMON_CLK
> -	bool
> +	tristate "Common Clock"
>  	select HAVE_CLK_PREPARE
>  	select CLKDEV_LOOKUP
>  	select SRCU

I told you yesterday that setting this to tristate allows over a dozen
new modules to be created. I'd be surprised if that doesn't break stuff
left and right without additional changes (which this patch lacks).

Thanks,

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/