linux-kernel - Re: [PATCH] perf unwind: Fix a compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55815F49.5040703@huawei.com>
Date:	Wed, 17 Jun 2015 19:51:37 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Hou Pengyang <houpengyang@...wei.com>
CC:	<namhyung@...nel.org>, <mingo@...hat.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf unwind: Fix a compile error



On 2015/6/16 21:47, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jun 16, 2015 at 11:16:35AM +0000, Hou Pengyang escreveu:
>> When libunwind is on, there is a compile error as :
>>
>> util/unwind-libunwind.c:363:21: error: 'dso' undeclared (first use in this function)
>>      dso__data_put_fd(dso);
>>
>> This patch fix it.
> Thanks, applied.
>
> - Arnaldo
>   

I just realized that I posted this patch several weeks ago and has been 
acked. Please see:

  http://lkml.kernel.org/r/CAM9d7cjkjcF_7AeZ0d7kyDLWwjutLpJm-MfdDR42tr=iQYnz6g@mail.gmail.com

I'll reply that post to note others about this one.

Anyway, thank you for fixing this problem.

>> Fixes: 4bb11d012ab248d0 ("perf tools: Add dso__data_get/put_fd()")
>> Signed-off-by: Hou Pengyang <houpengyang@...wei.com>
>> ---
>>   tools/perf/util/unwind-libunwind.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
>> index f079b63..4c00507 100644
>> --- a/tools/perf/util/unwind-libunwind.c
>> +++ b/tools/perf/util/unwind-libunwind.c
>> @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi,
>>   		unw_word_t base = is_exec ? 0 : map->start;
>>   
>>   		if (fd >= 0)
>> -			dso__data_put_fd(dso);
>> +			dso__data_put_fd(map->dso);
>>   
>>   		memset(&di, 0, sizeof(di));
>>   		if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name,
>> -- 
>> 1.8.5.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/