linux-kernel - Re: [PATCH v2 1/2] vTPM: support little endian guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1506161959240.23568@ant>
Date:	Tue, 16 Jun 2015 20:17:56 -0500 (CDT)
From:	Ashley Lai <ashley@...leylai.com>
To:	"Hon Ching(Vicky) Lo" <honclo@...ux.vnet.ibm.com>
cc:	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <PeterHuewe@....de>,
	Ashley Lai <ashley@...leylai.com>,
	Vicky Lo <honclo2014@...il.com>, linux-kernel@...r.kernel.org,
	Joy Latten <jmlatten@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/2] vTPM: support little endian guests

Just a small comment otherwise it looks good.

On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote:
> 	case NONHOST_INFO:
> -		name = tcpa_event_type_strings[event->event_type];
> +		name =
> +		    tcpa_event_type_strings[do_endian_conversion
> +					    (event->event_type)];
Not being picky but if it does not exceed 80 characters it looks better
to join the line above.
                name = tcpa_event_type_strings[do_endian_conversion
                                               (event->event_type)];

> 		case POST_CONTENTS:
> -			name = tcpa_pc_event_id_strings[pc_event->event_id];
> +			name =
> +			    tcpa_pc_event_id_strings[do_endian_conversion
> +						     (pc_event->event_id)];
Same as above.

Thanks,
--Ashley Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/