linux-kernel - Re: [PATCH] crypto: caam - fix non-64-bit write/read access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2015 07:30:53 -0700
From:	Victoria Milhoan <vicki.milhoan@...escale.com>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	Ruchika Gupta <ruchika.gupta@...escale.com>,
	Victoria Milhoan <Vicki.Milhoan@...escale.com>,
	Russell King <linux@....linux.org.uk>,
	"Jon Nettleton" <jon.nettleton@...il.com>,
	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel@...gutronix.de>
Subject: Re: [PATCH] crypto: caam - fix non-64-bit write/read access

On Tue, 16 Jun 2015 12:59:07 +0200
Steffen Trumtrar <s.trumtrar@...gutronix.de> wrote:

> The patch
> 
> 	crypto: caam - Add definition of rd/wr_reg64 for little endian platform
> 
> added support for little endian platforms to the CAAM driver. Namely a
> write and read function for 64 bit registers.
> The only user of this functions is the Job Ring driver (drivers/crypto/caam/jr.c).
> It uses the functions to set the DMA addresses for the input/output rings.
> However, at least in the default configuration, the least significant 32 bits are
> always in the base+0x0004 address; independent of the endianness of the bytes itself.
> That means the addresses do not change with the system endianness.
> 
> DMA addresses are only 32 bits wide on non-64-bit systems, writing the upper 32 bits
> of this value to the register for the least significant bits results in the DMA address
> being set to 0.
> 
> Fix this by always writing the registers in the same way.
> 
> Suggested-by: Russell King <linux@....linux.org.uk>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> ---
> 
> This patch is only compile-tested for PowerPC and tested on ARM.
> According to the datasheets for i.MX6 and P1010 this should be correct, though.

I can confirm that this patch works on both QorIQ/PowerPC and ARM devices.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/