linux-kernel - da2bc1b9db3351addd293e5b82757efe1f77ed1d breaks hibernation was Re: 4.1-rc7, thinkpad X60: platform mode hibernation does very wrongthing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2015 17:18:00 +0200
From:	Pavel Machek <pavel@....cz>
To:	Paul Bolle <pebolle@...cali.nl>, imre.deak@...el.com,
	ville.syrjala@...ux.intel.com, daniel.vetter@...ll.ch,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	linus <linus_torvalds@...mail.com>, lenb <lenb@...nel.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-acpi <linux-acpi@...r.kernel.org>,
	linux-pm <linux-pm@...r.kernel.org>
Subject: da2bc1b9db3351addd293e5b82757efe1f77ed1d breaks hibernation was Re:
 4.1-rc7, thinkpad X60: platform mode hibernation does very wrongthing

Hi!

> And this all reminded me of https://lkml.org/lkml/2015/3/18/133 . So I
> think that's another system not covered by commit ab3be73fa7b4
> ("drm/i915: gen4: work around hang during hibernation").

Yes, another system broken by

commit da2bc1b9db3351addd293e5b82757efe1f77ed1d
Author: Imre Deak <imre.deak@...el.com>
Date:   Thu Oct 23 19:23:26 2014 +0300

    drm/i915: add poweroff_late handler

    The suspend_late handler saves some registers and powers off the
    device,
        so it doesn't have a big overhead. Calling it at S4
    poweroff_late time
        makes the power off handling identical to the S3 suspend and
    S4 freeze
        handling, so do this for consistency.
	

And no, adding another system to the "blacklist" is a not good idea,
because we know there are other broken systems out there. Can we
revert da2bc1b9db3351addd293e5b82757efe1f77ed1d, please? Consistency
is nice, but not having regressions is even nicer.
									Pavel
									
PS: Now I have real Linus and fake Linus on the Cc list. Or maybe two
real Linuses, its hard to tell.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/