lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Jun 2015 17:58:28 +0200 From: Boris Brezillon <boris.brezillon@...e-electrons.com> To: Boris Brezillon <boris.brezillon@...e-electrons.com> Cc: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org, Arnaud Ebalard <arno@...isbad.org>, Tawfik Bayouk <tawfik@...vell.com>, Lior Amsalem <alior@...vell.com>, Nadav Haklai <nadavh@...vell.com>, Eran Ben-Avi <benavi@...vell.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Gregory CLEMENT <gregory.clement@...e-electrons.com>, Jason Cooper <jason@...edaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Andrew Lunn <andrew@...n.ch>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Jason Gunthorpe <jgunthorpe@...idianresearch.com>, Imre Kaloz <kaloz@...nwrt.org> Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support On Wed, 17 Jun 2015 17:34:02 +0200 Boris Brezillon <boris.brezillon@...e-electrons.com> wrote: > On Wed, 17 Jun 2015 23:08:08 +0800 > Herbert Xu <herbert@...dor.apana.org.au> wrote: > > > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote: > > > > > > Hi Herbert, > > > > > > I send you this patch alone so that you can verify I'm now properly > > > manipulating the SG list. Once I have your confirmation I'll send > > > the whole series again and annoy all the people in Cc one more time > > > ;-). > > > > Thanks. The only problem that I can see is the fact you're not > > checking for req->src == req->dst. If they're equal then you must > > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL. > > I can check for that too, but note that it doesn't prevent one from > providing different scatterlist structures pointing to the same memory > region. Actually, I don't know if it's a problem or not, so if it's not, please ignore my comment. > This being said, checking for req->src == req->dst should fix the case > where dst and src are pointing to the same scatterlist, which is a good > start. Here is an incremental patch [1], please let me know if something else is missing. Thanks, Boris [1]http://code.bulix.org/x8mz8x-88568 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists