linux-kernel - Re: perf: aux area related crash and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 11:09:55 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Vince Weaver <vincent.weaver@...ne.edu>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Stephane Eranian <eranian@...il.com>,
	"Paul E. McKenney" <paulmck@...ibm.com>
Subject: Re: perf: aux area related crash and warnings


* Alexander Shishkin <alexander.shishkin@...ux.intel.com> wrote:

> +void rb_free_aux(struct ring_buffer *rb)
> +{
> +	/*
> +	 * hold rb::refcount to make sure rb doesn't disappear
> +	 * before aux pages are freed
> +	 */
> +	if (WARN_ON_ONCE(!atomic_inc_not_zero(&rb->refcount)))
> +		return;
> +
> +	if (atomic_dec_and_test(&rb->aux_refcount))
> +		call_rcu(&rb->rcu_head, rb_free_rcu);
> +	else
> +		ring_buffer_put(rb);	/* matches the increment above */

Is call_rcu() NMI-safe? I don't think so ...

I think the life time rules of this object are really messed up if they can be 
freed from any fast path. How come the freeing can happen in NMI context? 
Shouldn't the hardware first stop, then we can free things from the system call 
path, or so?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/