linux-kernel - Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK=zhgrxXvDVGHMyiSaHq_=HgXcu7rbWjtc2n6QOeRuEzopfkA@mail.gmail.com>
Date:	Thu, 18 Jun 2015 15:30:00 +0530
From:	Sreekanth Reddy <sreekanth.reddy@...gotech.com>
To:	"jejb@...nel.org" <jejb@...nel.org>,
	Christoph Hellwig <hch@...radead.org>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Sathya Prakash <Sathya.Prakash@...gotech.com>,
	Kashyap Desai <kashyap.desai@...gotech.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tomas Henzl <thenzl@...hat.com>,
	Sreekanth Reddy <Sreekanth.Reddy@...gotech.com>
Subject: Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using
 handshake protocol only after HBA card gets into READY or Operational state.

Hi,

Any review comments on this patch. please let us known if any changes
are required.

Thanks,
Sreekanth

On Mon, Mar 30, 2015 at 7:25 PM, Sreekanth Reddy
<sreekanth.reddy@...gotech.com> wrote:
> Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state.
>
> This patch will make sure that
>  1.Driver to send IOC facts request message only if HBA is in operational or ready state.
>  2.If IOC is in fault state, a diagnostic reset would be issued.
>  3.If IOC is in reset state then driver will wait for 10 seconds to exit out of reset state.
>    If the HBA continues to be in reset state, then the HBA wouldn't be claimed by the driver.
>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@...gotech.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 65 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index c13a365..ce57320 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -3169,6 +3169,9 @@ _base_wait_on_iocstate(struct MPT3SAS_ADAPTER *ioc, u32 ioc_state, int timeout,
>   * Notes: MPI2_HIS_IOC2SYS_DB_STATUS - set to one when IOC writes to doorbell.
>   */
>  static int
> +_base_diag_reset(struct MPT3SAS_ADAPTER *ioc, int sleep_flag);
> +
> +static int
>  _base_wait_for_doorbell_int(struct MPT3SAS_ADAPTER *ioc, int timeout,
>         int sleep_flag)
>  {
> @@ -3711,6 +3714,61 @@ _base_get_port_facts(struct MPT3SAS_ADAPTER *ioc, int port, int sleep_flag)
>  }
>
>  /**
> + * _base_wait_for_iocstate - Wait until the card is in READY or OPERATIONAL
> + * @ioc: per adapter object
> + * @timeout:
> + * @sleep_flag: CAN_SLEEP or NO_SLEEP
> + *
> + * Returns 0 for success, non-zero for failure.
> + */
> +static int
> +_base_wait_for_iocstate(struct MPT3SAS_ADAPTER *ioc, int timeout,
> +       int sleep_flag)
> +{
> +       u32 ioc_state;
> +       int rc;
> +
> +       dinitprintk(ioc, printk(MPT3SAS_FMT "%s\n", ioc->name,
> +           __func__));
> +
> +       if (ioc->pci_error_recovery)
> +               return 0;
> +
> +       ioc_state = mpt3sas_base_get_iocstate(ioc, 0);
> +       dhsprintk(ioc, printk(MPT3SAS_FMT "%s: ioc_state(0x%08x)\n",
> +           ioc->name, __func__, ioc_state));
> +
> +       if (((ioc_state & MPI2_IOC_STATE_MASK) == MPI2_IOC_STATE_READY) ||
> +           (ioc_state & MPI2_IOC_STATE_MASK) == MPI2_IOC_STATE_OPERATIONAL)
> +               return 0;
> +
> +       if (ioc_state & MPI2_DOORBELL_USED) {
> +               dhsprintk(ioc, printk(MPT3SAS_FMT
> +                   "unexpected doorbell active!\n", ioc->name));
> +               goto issue_diag_reset;
> +       }
> +
> +       if ((ioc_state & MPI2_IOC_STATE_MASK) == MPI2_IOC_STATE_FAULT) {
> +               mpt3sas_base_fault_info(ioc, ioc_state &
> +                   MPI2_DOORBELL_DATA_MASK);
> +               goto issue_diag_reset;
> +       }
> +
> +       ioc_state = _base_wait_on_iocstate(ioc, MPI2_IOC_STATE_READY,
> +           timeout, sleep_flag);
> +       if (ioc_state) {
> +               dfailprintk(ioc, printk(MPT3SAS_FMT
> +                   "%s: failed going to ready state (ioc_state=0x%x)\n",
> +                   ioc->name, __func__, ioc_state));
> +               return -EFAULT;
> +       }
> +
> + issue_diag_reset:
> +       rc = _base_diag_reset(ioc, sleep_flag);
> +       return rc;
> +}
> +
> +/**
>   * _base_get_ioc_facts - obtain ioc facts reply and save in ioc
>   * @ioc: per adapter object
>   * @sleep_flag: CAN_SLEEP or NO_SLEEP
> @@ -3728,6 +3786,13 @@ _base_get_ioc_facts(struct MPT3SAS_ADAPTER *ioc, int sleep_flag)
>         dinitprintk(ioc, pr_info(MPT3SAS_FMT "%s\n", ioc->name,
>             __func__));
>
> +       r = _base_wait_for_iocstate(ioc, 10, sleep_flag);
> +       if (r) {
> +               dfailprintk(ioc, printk(MPT3SAS_FMT
> +                   "%s: failed getting to correct state\n",
> +                   ioc->name, __func__));
> +               return r;
> +       }
>         mpi_reply_sz = sizeof(Mpi2IOCFactsReply_t);
>         mpi_request_sz = sizeof(Mpi2IOCFactsRequest_t);
>         memset(&mpi_request, 0, mpi_request_sz);
> --
> 2.0.2
>



-- 

Regards,
Sreekanth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/