linux-kernel - Re: [PATCH] gpio: zynq: add missing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582AA80.8090603@xilinx.com>
Date:	Thu, 18 Jun 2015 13:24:48 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	<linux-gpio@...r.kernel.org>
CC:	Sören Brinkmann <soren.brinkmann@...inx.com>,
	"Michal Simek" <michal.simek@...inx.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	<linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] gpio: zynq: add missing module_exit function

On 06/17/2015 10:51 AM, Masahiro Yamada wrote:
> This driver is tristate, so it should be cleanable.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/gpio/gpio-zynq.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 184c4b1..1d38da7 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -722,6 +722,12 @@ static int __init zynq_gpio_init(void)
>  }
>  postcore_initcall(zynq_gpio_init);
>  
> +static void __exit zynq_gpio_exit(void)
> +{
> +	platform_driver_unregister(&zynq_gpio_driver);
> +}
> +module_exit(zynq_gpio_exit);
> +
>  MODULE_AUTHOR("Xilinx Inc.");
>  MODULE_DESCRIPTION("Zynq GPIO driver");
>  MODULE_LICENSE("GPL");
> 

Looks reasonable to me.

Tested-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/