linux-kernel - [tip:irq/core] irq: irq-keystone: Fix race in installing chained IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 05:08:35 -0700
From:	tip-bot for Russell King <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	ulli.kroll@...glemail.com, linus.walleij@...aro.org,
	mingo@...nel.org, lee.jones@...aro.org, hpa@...or.com,
	gnurou@...il.com, jason@...edaemon.net,
	rmk+kernel@....linux.org.uk, thierry.reding@...il.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [tip:irq/core] irq: irq-keystone:
  Fix race in installing chained IRQ handler

Commit-ID:  9414b6e2d55d0f7f07c3336d972818af366ae120
Gitweb:     http://git.kernel.org/tip/9414b6e2d55d0f7f07c3336d972818af366ae120
Author:     Russell King <rmk+kernel@....linux.org.uk>
AuthorDate: Tue, 16 Jun 2015 23:06:56 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 18 Jun 2015 14:03:08 +0200

irq: irq-keystone: Fix race in installing chained IRQ handler

Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
Cc: Alexandre Courbot <gnurou@...il.com>
Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Lee Jones <lee.jones@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>
Cc: Thierry Reding <thierry.reding@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0S-0002Ss-1V@rmk-PC.arm.linux.org.uk
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/irqchip/irq-keystone.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c
index 5dc6165..81e3cf5 100644
--- a/drivers/irqchip/irq-keystone.c
+++ b/drivers/irqchip/irq-keystone.c
@@ -184,8 +184,7 @@ static int keystone_irq_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, kirq);
 
-	irq_set_chained_handler(kirq->irq, keystone_irq_handler);
-	irq_set_handler_data(kirq->irq, kirq);
+	irq_set_chained_handler_and_data(kirq->irq, keystone_irq_handler, kirq);
 
 	/* clear all source bits */
 	keystone_irq_writel(kirq, ~0x0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/