linux-kernel - [tip:irq/core] gpio: gpio-tegra: Fix race in installing chained IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 05:08:17 -0700
From:	tip-bot for Russell King <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	gnurou@...il.com, tglx@...utronix.de, jason@...edaemon.net,
	linux-kernel@...r.kernel.org, thierry.reding@...il.com,
	lee.jones@...aro.org, rmk+kernel@....linux.org.uk,
	mingo@...nel.org, hpa@...or.com, linus.walleij@...aro.org,
	ulli.kroll@...glemail.com
Subject: [tip:irq/core] gpio: gpio-tegra:
  Fix race in installing chained IRQ handler

Commit-ID:  e88d251d6a4fb719f9f667a397cf5d755121e551
Gitweb:     http://git.kernel.org/tip/e88d251d6a4fb719f9f667a397cf5d755121e551
Author:     Russell King <rmk+kernel@....linux.org.uk>
AuthorDate: Tue, 16 Jun 2015 23:06:50 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 18 Jun 2015 14:03:08 +0200

gpio: gpio-tegra: Fix race in installing chained IRQ handler

Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
Cc: Alexandre Courbot <gnurou@...il.com>
Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Lee Jones <lee.jones@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>
Cc: Thierry Reding <thierry.reding@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0M-0002Sl-Ti@rmk-PC.arm.linux.org.uk
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/gpio/gpio-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 1741981..56dcc8e 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -515,8 +515,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
 	for (i = 0; i < tegra_gpio_bank_count; i++) {
 		bank = &tegra_gpio_banks[i];
 
-		irq_set_chained_handler(bank->irq, tegra_gpio_irq_handler);
-		irq_set_handler_data(bank->irq, bank);
+		irq_set_chained_handler_and_data(bank->irq,
+						 tegra_gpio_irq_handler, bank);
 
 		for (j = 0; j < 4; j++)
 			spin_lock_init(&bank->lvl_lock[j]);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/