linux-kernel - Re: [PATCH] iio: adc: at91_adc: allow to use full range of startup time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150618140232.GE27492@piout.net>
Date:	Thu, 18 Jun 2015 16:02:32 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	jic23@...nel.org, linux-arm-kernel@...ts.infradead.org,
	Josh Wu <josh.wu@...el.com>, leupold@...-elektrotechnik.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: at91_adc: allow to use full range of startup
 time

On 17/06/2015 at 18:21:36 +0200, Nicolas Ferre wrote :
> From: Jan Leupold <leupold@...-elektrotechnik.de>
> 
> The DT-Property "atmel,adc-startup-time" is stored in an u8 for a microsecond
> value. When trying to increase the value of STARTUP in Register AT91_ADC_MR
> some higher values can't be reached.
> 
> Change the type in function parameter and private structure field from u8 to
> u32.
> 
> Signed-off-by: Jan Leupold <leupold@...-elektrotechnik.de>
> [nicolas.ferre@...el.com: change commit message, increase u16 to u32 for startup time]
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

> ---
>  drivers/iio/adc/at91_adc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 8a0eb4a04fb5..7b40925dd4ff 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -182,7 +182,7 @@ struct at91_adc_caps {
>  	u8	ts_pen_detect_sensitivity;
>  
>  	/* startup time calculate function */
> -	u32 (*calc_startup_ticks)(u8 startup_time, u32 adc_clk_khz);
> +	u32 (*calc_startup_ticks)(u32 startup_time, u32 adc_clk_khz);
>  
>  	u8	num_channels;
>  	struct at91_adc_reg_desc registers;
> @@ -201,7 +201,7 @@ struct at91_adc_state {
>  	u8			num_channels;
>  	void __iomem		*reg_base;
>  	struct at91_adc_reg_desc *registers;
> -	u8			startup_time;
> +	u32			startup_time;
>  	u8			sample_hold_time;
>  	bool			sleep_mode;
>  	struct iio_trigger	**trig;
> @@ -779,7 +779,7 @@ ret:
>  	return ret;
>  }
>  
> -static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz)
> +static u32 calc_startup_ticks_9260(u32 startup_time, u32 adc_clk_khz)
>  {
>  	/*
>  	 * Number of ticks needed to cover the startup time of the ADC
> @@ -790,7 +790,7 @@ static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz)
>  	return round_up((startup_time * adc_clk_khz / 1000) - 1, 8) / 8;
>  }
>  
> -static u32 calc_startup_ticks_9x5(u8 startup_time, u32 adc_clk_khz)
> +static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz)
>  {
>  	/*
>  	 * For sama5d3x and at91sam9x5, the formula changes to:
> -- 
> 2.1.3
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/