linux-kernel - Re: [PATCH 3.4 035/172] ALSA: hdspm - Constrain periods to 2 on older cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55823878.7050108@huawei.com>
Date:	Thu, 18 Jun 2015 11:18:16 +0800
From:	Zefan Li <lizefan@...wei.com>
To:	Adrian Knoth <adi@...omp.erfurt.thur.de>
CC:	<lizf@...nel.org>, <stable@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 3.4 035/172] ALSA: hdspm - Constrain periods to 2 on older
 cards

>> @@ -6042,6 +6042,12 @@ static int snd_hdspm_capture_open(struct snd_pcm_substream *substream)
>>  		snd_pcm_hw_constraint_minmax(runtime,
>>  					     SNDRV_PCM_HW_PARAM_PERIOD_SIZE,
>>  					     64, 8192);
>> +		snd_pcm_hw_constraint_minmax(runtime,
>> +					     SNDRV_PCM_HW_PARAM_PERIODS,
>> +					     2, 2);
>> +		snd_pcm_hw_constraint_minmax(runtime,
>> +					     SNDRV_PCM_HW_PARAM_PERIODS,
>> +					     2, 2);
>>  		break;
>>  	}
> 
> This is not correct, those lines need to go to two different functions
> (snd_hdspm_playback_open and snd_hdspm_capture_open).
> 
> Here is how the patch should look like:
> 

Now fixed. Thanks for review the patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/