linux-kernel - Re: crypto: rsa - select on undefined AKCIPHER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582DBC9.6070606@intel.com>
Date:	Thu, 18 Jun 2015 07:55:05 -0700
From:	Tadeusz Struk <tadeusz.struk@...el.com>
To:	Andreas Ruprecht <andreas.ruprecht@....de>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Stefan Hengelein <stefan.hengelein@....de>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: crypto: rsa - select on undefined AKCIPHER

On 06/18/2015 01:26 AM, Andreas Ruprecht wrote:
> Hi Tadeusz,
> 
> your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
> implementation") was merged into linux-next today (i.e., next-20150618).
> It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
> 
> +config CRYPTO_RSA
> +	tristate "RSA algorithm"
> +	select AKCIPHER
> [...]
> 
> The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
> mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
> akcipher - add PKE API")?
> 
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
> automated, daily analysis of the most recent linux-next tree.
> There is also a tool in the Linux tree itself that can detect such
> issues (scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.

--- >8 ---
This patch fixes invalid config selection for AKCIPHER

Reported-by: Andreas Ruprecht <andreas.ruprecht@....de>
Signed-off-by: Tadeusz Struk <tadeusz.struk@...el.com>
---

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6c79ef0..b4cfc57 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER
 
 config CRYPTO_RSA
        tristate "RSA algorithm"
-       select AKCIPHER
+       select CRYPTO_AKCIPHER
        select MPILIB
        select ASN1
        help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/