lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGS+omCVFwHndKSN0A7PrYUArfPLfCoL6iiSJYEik1PVkMBrKA@mail.gmail.com>
Date:	Thu, 18 Jun 2015 23:16:32 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Eddie Huang <eddie.huang@...iatek.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: mt8173: Add I2C device node

On Wed, Jun 17, 2015 at 11:08 PM, Eddie Huang <eddie.huang@...iatek.com> wrote:
> Add MT8173 I2C device nodes, include I2C controllers and pins.
> MT8173 has six I2C controllers, from i2c0 to i2c6, exclude i2c5.
> The 6th I2C controller register base doesn't next to 5th I2C,
> and there is a hardware between 5th and 6th I2C controller. So
> SoC designer name 6th controller as "i2c6", not "i2c5".
>
> Signed-off-by: Eddie Huang <eddie.huang@...iatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 144 +++++++++++++++++++++++++++++++
>  1 file changed, 144 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index b52ec43..1816c8f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -158,6 +158,54 @@
>                         interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
>                                                 <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
>                                                 <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
> +
> +                       i2c0_pins_a: i2c0 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_45_SDA0__FUNC_SDA0>,
> +                                                <MT8173_PIN_46_SCL0__FUNC_SCL0>;
> +                                       bias-disable;
> +                               };
> +                       };
> +
> +                       i2c1_pins_a: i2c1 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_125_SDA1__FUNC_SDA1>,
> +                                                <MT8173_PIN_126_SCL1__FUNC_SCL1>;
> +                                       bias-disable;
> +                               };
> +                       };
> +
> +                       i2c2_pins_a: i2c2 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_43_SDA2__FUNC_SDA2>,
> +                                                <MT8173_PIN_44_SCL2__FUNC_SCL2>;
> +                                       bias-disable;
> +                               };
> +                       };
> +
> +                       i2c3_pins_a: i2c3 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_106_SDA3__FUNC_SDA3>,
> +                                                <MT8173_PIN_107_SCL3__FUNC_SCL3>;
> +                                       bias-disable;
> +                               };
> +                       };
> +
> +                       i2c4_pins_a: i2c4 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_133_SDA4__FUNC_SDA4>,
> +                                                <MT8173_PIN_134_SCL4__FUNC_SCL4>;
> +                                       bias-disable;
> +                               };
> +                       };
> +
> +                       i2c6_pins_a: i2c6 {
> +                               pins1 {
> +                                       pinmux = <MT8173_PIN_100_MSDC2_DAT0__FUNC_SDA5>,
> +                                                <MT8173_PIN_101_MSDC2_DAT1__FUNC_SCL5>;
> +                                       bias-disable;
> +                               };
> +                       };
>                 };
>
>                 watchdog: watchdog@...07000 {
> @@ -229,6 +277,102 @@
>                         clocks = <&uart_clk>;
>                         status = "disabled";
>                 };
> +
> +               i2c0: i2c@...07000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11007000 0 0x70>,
> +                             <0 0x11000100 0 0x80>;
> +                       interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;

According to the i2c-mt6577 dt binding:
   - clock-div: the fixed value for frequency divider of clock source in i2c
     module. Each IC may be different.

For other drivers I've seen this kind of hardware-specific value
implemented as a table in the driver that is indexed based on the
compatible.

Any particular reason to specify it here in every device tree node instead?

-Dan


> +                       clocks = <&pericfg CLK_PERI_I2C0>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c0_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c1: i2c@...08000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11008000 0 0x70>,
> +                             <0 0x11000180 0 0x80>;
> +                       interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;
> +                       clocks = <&pericfg CLK_PERI_I2C1>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c1_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c2: i2c@...09000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11009000 0 0x70>,
> +                             <0 0x11000200 0 0x80>;
> +                       interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;
> +                       clocks = <&pericfg CLK_PERI_I2C2>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c2_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c3: i2c3@...10000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11010000 0 0x70>,
> +                             <0 0x11000280 0 0x80>;
> +                       interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;
> +                       clocks = <&pericfg CLK_PERI_I2C3>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c3_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c4: i2c4@...11000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11011000 0 0x70>,
> +                             <0 0x11000300 0 0x80>;
> +                       interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;
> +                       clocks = <&pericfg CLK_PERI_I2C4>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c4_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c6: i2c6@...13000 {
> +                       compatible = "mediatek,mt8173-i2c";
> +                       reg = <0 0x11013000 0 0x70>,
> +                             <0 0x11000080 0 0x80>;
> +                       interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-div = <16>;
> +                       clocks = <&pericfg CLK_PERI_I2C6>,
> +                                <&pericfg CLK_PERI_AP_DMA>;
> +                       clock-names = "main", "dma";
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c6_pins_a>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
>         };
>
>  };
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ